Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove usage of NHIBERNATE_BOT_TOKEN #3574

Merged
merged 1 commit into from
Jul 2, 2024
Merged

Remove usage of NHIBERNATE_BOT_TOKEN #3574

merged 1 commit into from
Jul 2, 2024

Conversation

hazzik
Copy link
Member

@hazzik hazzik commented Jul 2, 2024

No description provided.

@hazzik hazzik enabled auto-merge (squash) July 2, 2024 10:08
@hazzik hazzik disabled auto-merge July 2, 2024 10:08
@fredericDelaporte
Copy link
Member

fredericDelaporte commented Jul 2, 2024 •
edited
Loading

Shouldn't it target the lowest supported version, 5.4.x, to allow removal of the token?

@hazzik hazzik merged commit a998c11 into nhibernate:master Jul 2, 2024
24 checks passed
@hazzik hazzik deleted the generate-async branch July 2, 2024 23:03
@hazzik
Copy link
Member Author

hazzik commented Jul 2, 2024

Can back-port later if needed

@fredericDelaporte fredericDelaporte added this to the 5.6 milestone Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredericDelaporte fredericDelaporte fredericDelaporte approved these changes

Assignees
No one assigned
Labels
c: Async p: Minor r: Fixed t: Task
Projects
None yet
Milestone
5.6
Development

Successfully merging this pull request may close these issues.
2 participants
@hazzik @fredericDelaporte